Cities can be the best places for photography, and New York is definitely one of the best. You can be inside an incredibly old and detailed church, and walk out to a beautiful modern building. You can take picture of monuments, statues, parks, train terminals, and more without leaving a few square blocks.
The city is one of the only places I go where I don't pre-plan everywhere I am going to shoot since I never know what I'm going to find. The city is also one of the only places where you will find photo-walking tours almost every day.